Skip to content

Wdfn 914 - Center elements in the hydrograph

Williams, Darius Shamar requested to merge dswilliams/waterdataui:wdfn-914 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

Added a slot for elements that should be centered in the hydrograph. Moved the hydrograph title element out of the core container for the hydrograph so it no longer affects the centering. Modified tests to remove loading indicator/no data element checks if the test suite does not fully mount the components such that the templates get rendered in child components.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports