Skip to content

WDFN-915 - Add Pinia store to replace hydrographParameters in Redux and implemente Latest IV Value row in Data details

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-915 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

This MR accomplished two major changes: creation and use of Pinia to store the available IV data meta data and the implementation of the Latest value row for IV data in the Data Details section.

The Pinia store, available-iv-data-store, has an action which fetches the IV Data for a site with no time parameter. This data provides all of the meta data for all parameter codes and methods for the site along with the last value that was recorded for each data. The action also adds an calculated IV meta data and the period of record for all data. Getters were added to retrieve information by parameter code, by parameter code and method id. This hydrographParameters in the Redux store along with its selectors. Right now, hydrographParameters is still in the code base as the StatisticsTable component uses it and as this will be removed once the DataDetails section is complete, I opted not to spend the time to change that to use the new Pinia store. In addition gw level visit meta data will now only be fetched from the groundwaterLevelData section of the Redux store.

Implemented a new DataDetailsLastValueRow component which uses the DataDetailsBaseGridRow. I also pulled out the approvals and masked qualifiers into a new module, iv-data-qualifiers. Right now only the Latest Value row is using this information. Once we get complete information on how we want different approvals to be rendered we will likely want to use this module when determining the classes and masks for the rendered IV data, legend and selected rows.

Screen_Shot_2023-01-12_at_10.00.33_AM

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.
Edited by Bucknell, Mary S.

Merge request reports

Loading