Skip to content

Remove screenDetails and replace with screenCategory which is a reactive string variable. Also mock useMediaQuery.

Bucknell, Mary S. requested to merge mbucknell/waterdataui:fix_vue_warnings into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

Made two changes. Where useMediaQuery (or usePageTitle) is used, mock that function in the test code so that we don't get Vue warnings and we can write our test cases without mocking media query or relying on the function result to test whether the function was called.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports