Before making a pull request
-
Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/) -
Run all linters (make lint) -
Run all tests (make test) -
Update the changelog appropriately -
If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
- Introduces Vue Apollo to handle interacting with GraphQL server.
- Adds a Pinia store to handle state and actions associated with data fetching and retrieval from GraphQL.
There are various moving parts and decisions still being made to how the map operates with the amount of data being sent back. The map can get overwhelmed visually and slow down performance when there are lots of markers being added.
I had a code review session with Aaron to give a high level overview of what is going on and where we are at right now. There are stories coming up that will handle more of the interactions that will overtake the static display of the filters and way the map functions based on those filters being set.
After making a pull request
-
If appropriate, put the link to the PR in the JIRA ticket -
Assign someone to review unless the change is trivial -
Check the accessibility CI step and fix or explain any issues.