Skip to content

WDFN-893 Move view data options

Briggs, Aaron Shane requested to merge abriggs/waterdataui:WDFN-893_Move_view_data_options into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

WDFN-893 Move view data options

This makes a copy of the data tables and the 'retrieve data' options in the new buttons container

I made a new component called 'DataTables.vue' to facilitate the movement. This allowed the entire data tables section to moved as a unit to the new location.

In the process of making these changes I noticed an issued with the paginated table conflicting with the 'sticky' comments feedback tab on mobile. After investigating, I am sure that this issue has nothing to do with the changes here and is a pre existing issue with the paginated table. If remove all of the new code changes and then move the paginated table out of the accordion where it is currently located, I see the issue. I'm not sure what magic the current accordion provides that allows the Questions or Comments tab to work, but the paginated table should be useable outside of the accordion.

Image - new View data section desktop

image

Image - new View data section mobile

image

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports