Skip to content

WDFN 895 Move Subscribe to WaterAlert

Briggs, Aaron Shane requested to merge abriggs/waterdataui:WDFN-895_move_subscribe_to_wateralert into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description WDFN 895 Move Subscribe to WaterAlert

This sets up the subscribe for WaterAlert section in the new toggle buttons.

Of note -

  • the link to WaterAlert is not specific for a data type (this seems reasonable since the selections are separate from the graph, but it could also be argued that these links should work like the old version in the data types selection table). The upside of this is the code is simpler and there is no need to deal with the calculated parameter. The downside is the user will need to read through the data types list in WaterAlert
  • There is not any filtering added for locations that may have no IV data and therefore no WaterAlert. To implement this, we would need to think through the various fringe cases and add a sensible message to the user as to why WaterAlert is not available. This could get complicated.

Image - new Subscribe section - desktop

image

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports