WDFN-955 - Cleanup of the work to add the consolidated hydrograph controls
Before making a pull request
-
Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/) -
Run all linters (make lint) -
Run all tests (make test) -
Update the changelog appropriately -
If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.
Description
Removed the compare/median graph controls, the select actions bar, and the statistics table section. Move the provisional tag directly below the statistics grid and above the slider controls button section. Removed the DATA_DETAILS_ENABLE feature flag.
In addition to this, I did a pass through the HydrographApp components to see if any of the markup could be simplified like removal of divs that were not required. I also checked to see if the appropriate aria attributes are being used on the custom control components that we have created. In addition, I updated the StatisticsGrid component to use the availableIvDataStore and the selected parameter codes. This store now includes what methods are available for each available IV parameter code and can be used rather than the fetched hydrograph data to determine whether a selected parameter code has multiple methods. This greatly simplifies the code and testing of the code. There are likely other opportunities for this kind of change. I am planning on opening a ticket whose goal is to remove any remaining dependencies on hydroggraphParameters and any other places where we are using the retrieved hydrographData to determine whether a parameter code has multiple methods.
I also did some test cleanup as as things moved around, in appropriate tests were left in inadvertently. I suspect I did not catch everything.
After making a pull request
-
If appropriate, put the link to the PR in the JIRA ticket -
Assign someone to review unless the change is trivial -
Check the accessibility CI step and fix or explain any issues.