Skip to content

WDFN-902 Add Date Filter to Hydrograph Table

Briggs, Aaron Shane requested to merge abriggs/waterdataui:WDFN-902_add_date_filter_to_table into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

WDFN-902 Add Date Filter to Hydrograph Table

This takes the text input filter Mary created for the 'Summary of all Field . . ." table and converts it to a reusable component which was then added to filter the data column of the hydrograph data tables.

Of note - the ticket asks that one filter filters all the tables shown. This turned out to be quite complicated due to the nature of the Vue watchers and the nested structure of the 'hydrographData' in the state. There most likely is a way around this issue, but since we don't know users will prefer as single filter for all tables or a filter for each table, I implemented a filter for each table, which was achievable without complication.

Image - Hydrograph data tables with new filters

image

Image - message when no data matches filter

image

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports