Skip to content

WDFN-941 - Adjusted the markup to use the main tag appropriately and moved the in-page navigation to fill the right side of the available screen.

Bucknell, Mary S. requested to merge mbucknell/waterdataui:wdfn-941 into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

The changes required changing the base.html template to remove the enclosing main tag. Instead in each template that inherits from base.html in the "content" block, the main tag should be used as appropriate. For in page navigation, it needs to be used for the page content part and should not include the in-page navigation. Also made some styling adjustments to use grid-container when appropriate as it should only be used when we want to limit the width of the div on desktop to 1024px and to allow the in-page navigation to take up more space.

Screen_Shot_2023-02-06_at_9.06.04_AM

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports