Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • W waterdataui
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar

The GitLab email notification service is currently down. Users will not receive email notifications for any GitLab actions or activity. CHS has scheduled maintenance for Monday, April 3rd at 15:00 MST to address the issue. Expected downtime <1 hour.

  • Water Mission Area
  • Internet of Water
  • waterdataui
  • Merge requests
  • !741

WASP-350: Search and Filter Map and Legend Integration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Simpson, Robert (Contractor) Evan requested to merge wasp-350-map-with-filters into main Feb 07, 2023
  • Overview 1
  • Commits 33
  • Changes 23

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

This is a follow up merge request based off of !726 (closed) which was closed because of the amount of comments making it hard to see the changes taking place.

This introduced the integration of the Location Type(s) filters with the API data that updates the markers on the map. Once the filters are selected, the legend below the map will update to show the location types being filtered.

Note that there is still work needed to get full coverage on the GraphQL implementation. One option could be moving away from onResult and onError in favor of exposing result, loading, and error returned from useQuery. Other options include moving this functionality into a composable that can be tested in isolation, or moving away from handling this in the store and using one of the components available as a wrapper from Vue Apollo. Right now the coverage can be seen below for the store showing where the coverage is missing.

I tried to use the recommendation from vitest for graphql using mock service worker - https://mswjs.io/ - and did not see it working correctly. That does not mean it will not work, but I would need more time to allocate for that integration.

Screenshot_from_2023-02-07_14-34-24

With this new merge request, it is the hope that reviewing will be easier without the noise of the comments found in 726.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.
Edited Feb 07, 2023 by Simpson, Robert (Contractor) Evan
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wasp-350-map-with-filters