Skip to content

WDFN-957 Questions or Comments tab sticking to paginated table

Briggs, Aaron Shane requested to merge abriggs/waterdataui:WDFN-957_questions_or_comments_tab_sticking_to_paginated_table into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

WDFN-957 Questions or Comments tab sticking to paginated table

On mobile screens, the time column text was overflowing the paginated table. This overflow was cascading upward and confusing the 'sticky' property of the Question or Comments tab which was then stinking the wrong page elements.

Since there are multiple usability issues with this table on mobile devices, I looked for a stop-gap measure that would just get things running again. So I added a containing div within the DataTables.vue component and confined the any x-overflow to a scroll condition. This allows the 'sticky' property of the Questions comments tab to function as expected.

Note -- I don't have a method of testing the 'zero-height-hydrograph' as seen on Safari and thought to be related to this issue. So, if that turns out to still be a problem, we will have to address that in a different ticket.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports