Skip to content

WASP-335: Search and Filter - Re-introduce map events and popover change

Simpson, Robert (Contractor) Evan requested to merge wasp-335-site-details-fix into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

The events that are needed for making a call to the service are brought back in so it is explicit that the call should only happen for these events. For moveend, it caused an issue where the popover that is partially outside the bounds of the map will redraw the map and make a call to the service. This is now fixed.

The location name is now shown in the popover as expected in the acceptance criteria.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports