Skip to content

Search and Filter - Update App and App Test

Simpson, Robert (Contractor) Evan requested to merge search-app-tests-update into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

Description

Updates based on findings that @mbucknell uncovered with issue where the SearchMap component was being tested when App test ran. This is handled by setting shallow to true. Then the next issue came about where the mapBound was null during the test run. To handle this, nullish coallescing is being used so the value will be 0 when the mapBounds is null. I went with this approach so leaflet would not have to be imported only for this situation.

Not associated with any JIRA tickets

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports