Skip to content

WDFN-953 Add Monitoring Location Input for Combined Graph

Briggs, Aaron Shane requested to merge abriggs/waterdataui:WDFN-953_add_input_field_combined_graph into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

WDFN-953 Add Monitoring Location Input for Combined Graph

This adds a input field to 'bulk' input locations for the combined location graph. The input automatically filters out impossible location IDs such as those that contain letters, or are too short. The entries into the field are filtered as the user types and then the updated list of possible location IDs are shown in a list below. This eliminates the need for the user to actively 'submit' the list each time changes are made which would make for a poor user experience. The form also actively tells the user how many more locations they can add and when they have added too many.

Image - Combined Location Graph with 'bulk' location input image

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.
Edited by Briggs, Aaron Shane

Merge request reports