Skip to content

WDFN-937 Deliver only SIMS Alerts that are Active

Briggs, Aaron Shane requested to merge abriggs/waterdataui:WDFN-937_deliver_only_sims_alerts_that_are_active into main

Before making a pull request

  • Put the appropriate EXEMPT flag if needed in the MR label (see https://practices.wma.chs.usgs.gov/practice/peer_code_review/)
  • Run all linters (make lint)
  • Run all tests (make test)
  • Update the changelog appropriately
  • If making a release, update code.json metadataLastUpdated and bump CHANGELOG.md to next version.

WDFN-937 Deliver only SIMS Alerts that are Active

Checks the Site Information Management System (SIMS) data for start and end dates and compare them to the current time to see if the message should be shown.

I added this check to all three of the SIMS data parts, 'alerts', 'dataObservationContext', and 'endangermentStatus'. I'm not sure if any of the data parts other than 'alerts' have this information, but it doesn't hurt to check.

After making a pull request

  • If appropriate, put the link to the PR in the JIRA ticket
  • Assign someone to review unless the change is trivial
  • Check the accessibility CI step and fix or explain any issues.

Merge request reports