Skip to content

Follow-up from "Style changes/ non-contributing area work"

The following discussions from !36 (merged) should be addressed:

  • @dblodgett started a discussion:

    Are these all still todo? Should get them out into issues.

  • @dblodgett started a discussion:

    Need to parameterize this 10!!

  • @dblodgett started a discussion:

    Do you need the "." here?

  • @dblodgett started a discussion:

    I still don't know what these really are -- can should open an issue to review and figure out what's going on.

  • @dblodgett started a discussion:

    What is slice doing here? I usually filter row_number() == 1 if I want first row. Is that this?

  • @dblodgett started a discussion:

    More parameterization

  • @dblodgett started a discussion:

    this seems kinda magic -- I'd comment why you are using 0 in this case.

  • @dblodgett started a discussion:

    Huh?

  • @dblodgett started a discussion:

    I'm ok leaving commented code, but leave behind why it's commented so someone else knows why this was useful for debugging.

  • @dblodgett started a discussion:

    Did you mean to leave this uncommented?

  • @dblodgett started a discussion:

    I think we need to look at a more consistent way to handle this kind of config stuff.

    I have a config.R file out in the workspace directory that contains this kind of stuff.

    I think we should probably just unify all this stuff.

  • @dblodgett started a discussion:

    TODO: convert to roxygen.

    We should consider making a package for some of these functions going forward.

Edited by Bock, Andy