Isolated burn line events can flow the wrong direction + need to bring back fix_headwaters()

When there's no network to check, we need to use the preexisting flowline outlet location to check the flow direction of burn line events. This can probably be fixed in hydroloom by pulling out the outlet location selection step in fix flow direction rather than using the full network as the source of truth.

I'm also noting that we removed the workflow to generate the reference flowline input because it moved to my mainstems project. The burnLinEevent part of that did NOT move to mainstems and needs to come back.

2d970f6f

assigned to @dblodgett

@dblodgett - Is this fixed with the latest modifications from Greg/Sparrow?

oh... probably not. I'll get it in and rerun the geometry cleanup. It won't alter the network stuff so it shouldn't be a big deal.

Actually, hold on, no. That work didn't bring in the burn line events. That will have to happen over here.

changed title from Isolated burn line events can flow the wrong direction. to Isolated burn line events can flow the wrong direction + need to bring back fix_headwaters()

changed the description

mentioned in issue #161

This is currently taken care of here: https://github.com/owp-spatial/reference.fabric/blob/main/R/targets-flowlines.R#L125

We will need to get the burn line event direction fix implemented over there.

This should be fixed in the next release with this: https://github.com/owp-spatial/reference.fabric/pull/5#issuecomment-2558516756

I want to keep the burnline event overlay happening in that project and expect the digitization direction to be valid from that step of the broader workflow going forward.

closed