usgs-review: functionality
A few test scenarios were conducted to help identify if results were as expected. Functionality worked as expected but the following potential issues were noted. If these results are as expected I would suggest updating documentation to communicate this to users.
-
Resolution of results seems to differ between returned polygons. Mostly noting this, but if this is intended ensure Docs let the user know when geometries are generalized vs. full resolution. From testing scenarios it appeared splitcatchment returns a generalized full catchment but possibly a higher resolution sub catchment (30m resolution like the NHDPlus). Looks like generalization may be happening in “utils.merge_geometry”? -
When running the following example there appears to be a disconnect in the flowtrace line connecting the pourpoint and the intersection point. Also the intersect line doesn't seem to fully line up with the NHDPlusV2 flowline. See below image, which is a geopackage output of the results x,y = -113.215,36.1073 # query point flowpath = flowtrace(x,y, 'down')