Skip to content
Snippets Groups Projects
  1. Oct 21, 2024
  2. Oct 15, 2024
  3. May 28, 2024
    • Erin (Josh) Rigler's avatar
      Pull inputs in run(), not run_as_update() · dd71bde9
      Erin (Josh) Rigler authored
      For years, when invoking geomag-algorithms' update mechanism, inputs
      were pulled and checked from the run_as_update() method inside the
      Controller class. I never understood this. It seemed to break the
      logic of the update mechanism if no inputs were available for the
      current inteval/gap. This might even be the source of noted issues
      where running back-filling scripts didn't behave as expected, and
      those scripts needed to be run multiple times.
      
      What's more, the run_as_update() method logically seems like the
      most appropriate place to read *outputs* and check for gaps. Whereas
      the run() method seems like the most appropriate place to read
      inputs, apply algorithms, and write out outputs.
      
      In any case, this change should not break any existing code. It
      should only allow the update mechanism to complete, every time, and
      as originally intended, rather than be short-circuited when input
      data are missing for the current interval (but might be available
      for previous intervals)..
      dd71bde9
  4. Apr 22, 2024
    • Erin (Josh) Rigler's avatar
      Fix Controller.run_as_update() · 126d6e14
      Erin (Josh) Rigler authored
      This broke when changes were made to allow processing data more recent than
      the last top-of-the-minute (~8 months ago). The only "updates" that worked
      since then were for 1-second data. It's a little bit lazy because it relies
      on the output_factory to return traces with proper starttimes and endtimes
      (that is, they fall on the tops of minutes). Probably we should be more
      explicit in correcting the starttimes and endtimes to line up on expected
      timestamps. Pushing this fix now because it has operational impacts.
      126d6e14
  5. Aug 24, 2023
  6. Aug 16, 2023
  7. Apr 25, 2023
  8. Apr 24, 2023
  9. Jan 13, 2023
  10. Aug 13, 2022
  11. Aug 12, 2022
  12. Aug 11, 2022
    • Erin (Josh) Rigler's avatar
      update interval no longer shrinks with recursion · 6355305d
      Erin (Josh) Rigler authored
      Previously, the endtime-starttime interval being processed by the
      `run_as_update` method would shrink by 1 (second) with each recursion.
      This ultimately broke `run_as_update` when processing anything other
      than 1-second data, but it wasn't obvious because we rarely had to
      actually recurse. There is a little trickery now to ensure that user-
      provided starttime and endtime are inclusive of the full first
      (most recent) update interval, while subsequent, calculated, endtimes
      are set equal to the prior starttime minus specified output_interval
      (e.g., 'second', 'minute', etc.).
      6355305d
  13. May 27, 2022
    • Erin (Josh) Rigler's avatar
      Remove BYTESIO object creation · e918b4c9
      Erin (Josh) Rigler authored
      It turns out that none of the factories currently being used in
      production expects bytes as input, and in fact, Util.read_url()
      converts everthing to a string anyway, so a BYTES-oriented input
      would couldn't not possibly be working. So, just remove all use
      of BYTESIO, and instead use only STRINGIO.
      e918b4c9
  14. May 18, 2022
  15. Aug 26, 2021
  16. Aug 25, 2021
  17. Aug 18, 2021
  18. Aug 16, 2021
  19. Mar 22, 2021
  20. Mar 19, 2021
  21. Mar 15, 2021
  22. Feb 02, 2021
  23. Jan 20, 2021
  24. Dec 17, 2020
  25. Nov 24, 2020
  26. Oct 27, 2020
  27. Oct 26, 2020
  28. May 26, 2020
  29. May 22, 2020
Loading