Skip to content
Snippets Groups Projects

Remove trimming of base_directory in spreadsheet factories

All threads resolved!

Removed trimming of base_directory in spreadsheet factories. This was trimming the user-defined base_directory in the SpreadsheetAbsolutesFactory.py and then again in the SpreadsheetSummaryFactory.py. For my defined directory, this error was causing the factories to search all of "home/awernle" for relevant spreadsheets instead of "home/awernle/programming/all_spreadsheets". This inevitably found irrelevant files with relevant patterns such as BOU2016adj.min which caused the scripts to fail.

I am not sure what the point of this logic was but I am committing this small change due to the problems it can create.

Edited by Wernle, Alexandra Nicole

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Erin (Josh) Rigler
  • added 1 commit

    • c36bcec9 - Added if statement to base_directory in case directory entered is path to file.

    Compare with previous version

  • Wernle, Alexandra Nicole resolved all threads

    resolved all threads

  • Erin (Josh) Rigler approved this merge request

    approved this merge request

  • Wernle, Alexandra Nicole marked this merge request as ready

    marked this merge request as ready

  • mentioned in commit c4237e21

  • mentioned in issue #71 (closed)

  • Please register or sign in to reply
    Loading