Cumulative Calculation Handle Incomplete Years
From #26 (closed) and !33 (merged).
@shamshaw said:
@jhariharan on the partial years plotting on cumulative hydrographs, so we put in
if len(year_data) == 365:
to limit to full years. That prevents years where there was a gap in monitoring from being shown. That makes sense, but we don't want that to apply to the latest in progress years where data isn't missing, but just not complete. Maybe add an argument of allow_incomplete_yrs and set to True by default?Maybe there is another check that could be done, but the above seems simple
Sounds good, though we should check that if there is a gap in data, we would want that carried through the cumulative values and plots. In other words, we don't want available data getting all stacked together. If that is complicating things, maybe we can handle plotting the in progress year another way. Can push this to a separate issue if complicating things.
I don't think we should add this in unless we handle data gaps, so we can revert back. Let's just create an issue to not lose track of this as an enhancement to make down the line.