Skip to content

Closes: Issue-459

Martinez, Eric M. requested to merge ghsc/users/emartinez/earthquake-design-ws:issue-459 into master

Closes #459 (closed)

Updated QC tests for NEHRP-2020. This revealed a few errors that needed to be corrected as well:

  • DET Floor values were incorrect for some regions.
  • Handling null PGAD values was incorrect.
  • Floating point precision errors caused some rounding discrepancies.
  • Non-inclusive boundary check when calculating SDC

The above four issues were all addressed as part of this merge request. There were four additional discrepancies (all documented in errata.md) which were determined to be problems with the MatLab code rather than the application source code.

In reviewing this merge requests, the metadata will need to be reloaded. If your copy of the database does not include the updated data (as of !484 (merged)), then data will need to be reloaded as well.

Upon merging, allow the default pipelines to finish, but then also trigger a development deployment with a full data load. Do this in two separate jobs for dev01 and dev02. Do not deploy to production just yet.

Edited by Martinez, Eric M.

Merge request reports