- better handle hour and day intervals in create_empty_trace
- enode_stream now handles "STEIM" encoding
- fixed bug in pad_and_trim_trace

The split_trace() function always dropped the last sample. This was
seemingly part of a flawed logic designed to prevent traces being
written to Edge by the MiniSeedInputClient that spanned midnight.
This worked, but only if the original trace actually spanned midnight.
For the majority of data that do not span midnight, this dropped a
sample every time. The updated logic does what I believe was the
original intent (that is, it breaks traces into more manageable
chunks) without duplicating or losing any data. This is consistent
with obspy's concept of data slices, where a starttime and endtime
are always inclusive, but it deviates somewhat from MiniSeed logic,
which assumes a starttime, plus a delta, plus a number of samples.

It was necessary to update a couple unit tests for the MiniSeedFactory
to work with this new logic, but I am certain that the original test
logic was not based on anything but what the TimeseriesUtility.py
function(s) returned when they were originally written.

The has_any_channels method in TimeseriesUtility.py did not properly
handle streams with multiple traces with the same channel, but different
stations (or networks, or locations). It should work now.

The method TimeseriesUtility.get_stream_gaps() would over-write gaps[channel] if
there were multiple Traces in a stream that were the same channel, but different
observatories. This is a typical situation when using the AverageAlgorithm.

instead of deprecated microsecond property setter.

Add test for round-to-next-second branch.

Applied the same fix to the trim logic in method
TimeseriesUtility.pad_and_trim_trace() as previously applied
to the pad logic. Added a unit test that would have failed
using the old logic.

The first attempt to fix TimeseriesUtility.pad_and_trim_trace() broke
a unit test. I'm not sure I agree with what the unit test defined as
passing, but I do understand the logic. This now satisfies the logic
of the unit test(s), while still fixing the floating point precision
problem to the default resolution of UTCDateTime objects (that is,
1e-6 or microseconds)

I ran into a floating point precision issue when padding a trace out
to the requested starttime when the data block returned by the Edge
miniseed factory (but this is not an Edge issue, per se) was less
than what was requested.

My solution was to use `round()` instead of `int()` when converting
a time differential to a discrete number of samples. I'm confident
this is a robust fix for padding. I'm not sure if it also the proper
approach to the trimming, which seems to be a bit more sophisticated
in that is uses the `ceil()` method. In any case, I request some
feedback before merging this deceptively simple PR.

Jeremy M Fee authored 6 years ago and Claycomb, Abram Earl committed 6 years ago

Add "without_gaps" option to get_stream_start_end_times, add "pad_and_trim_trace" method and update pad_timeseries to use it