Skip to content
Snippets Groups Projects
  1. Nov 01, 2024
  2. Oct 31, 2024
  3. Oct 29, 2024
  4. Oct 22, 2024
  5. Oct 21, 2024
  6. Oct 15, 2024
  7. Sep 27, 2024
  8. Sep 26, 2024
  9. Sep 24, 2024
  10. Sep 23, 2024
    • Wilbur, Spencer Franklin's avatar
    • Erin (Josh) Rigler's avatar
      Merge branch 'fix-FilterAlgorithm-get_nearest_time' into 'master' · 84a6f967
      Erin (Josh) Rigler authored
      Function get_nearest_time() behaves as expected now
      
      See merge request !338
      84a6f967
    • Erin (Josh) Rigler's avatar
      Fix unit test for FilterAlgorithm.get_nearest_time() · 426ad8d4
      Erin (Josh) Rigler authored
      The previous unit test relied on broken behavior of get_nearest_time()
      to pass. With get_nearest_time() fixed, the unit test needed to be
      updated accordingly.
      426ad8d4
    • Erin (Josh) Rigler's avatar
      Function get_nearest_time() behaves as expected now · ffdb80da
      Erin (Josh) Rigler authored
      A FilterAlgorith.py module function get_nearest_time() is supposed to return
      the nearest *allowed* time for a given filter "step". This worked fine with
      steps for second and minute data, whose allowed times are the tops of seconds
      and minutes. However, for hourly (and daily, and any "average" type step),
      things failed since the allowed times are the center of the interval (for
      example, for hourly data, which is the average of all minute samples from
      00 to 59, the the allowed time is 29:30).
      
      One consequence was that if a user specified an interval with a start and
      end time that did not encompass a given hour's allowed center time (e.g.,
      start=AA:29:31, end=BB:29:29), the algorithm would still return a sample
      for time BB:29:30. More generally, requests for average type data would
      include an extra sample.
      
      In this fixed version, if start=AA:29:31, and end=BB:29:29, nothing is
      returned, as intended (and as always worked for non-average type steps).
      Furthermoref start=AA:29:30, and end=BB:29:29, a sample for hour AA is
      generated; if start=AA:29:31, and end=BB:29:30, a sample for hour BB is
      generated, and if start=AA:29:30, and end=BB:29:30, samples for both AA
      and BB are generated, all as intended.
      ffdb80da
  11. Sep 20, 2024
  12. Sep 19, 2024
Loading